Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where Compiler was not available #1471

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Conversation

joelhawksley
Copy link
Member

What are you trying to accomplish?

Fix #1468

What approach did you choose and why?

I required the file in question.

Anything you want to highlight for special attention from reviewers?

No.

@joelhawksley joelhawksley requested a review from a team as a code owner August 15, 2022 21:45
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I wonder why the autoload in lib/view_component.rb doesn't handle this?

@joelhawksley
Copy link
Member Author

Weird, I wonder why the autoload in lib/view_component.rb doesn't handle this?

I wonder too. I notice that some files are required in base and some are not. Still, I'm preferring to get folks unblocked here while we investigate.

@joelhawksley joelhawksley merged commit 21ccd88 into main Aug 15, 2022
@joelhawksley joelhawksley deleted the fix-compiler-ref branch August 15, 2022 22:18
@Spone
Copy link
Collaborator

Spone commented Aug 15, 2022

This kind of issue should no longer happen when moving to Zeitwerk #1378 :)

@joelhawksley
Copy link
Member Author

@Spone agreed, want to add it?

@Spone
Copy link
Collaborator

Spone commented Aug 16, 2022

@joelhawksley I spent some time on it already, but it's not working yet :)

claudiob pushed a commit to claudiob/view_component that referenced this pull request Dec 22, 2023
* fix bug where Compiler was not available

* add changelog

* vale
claudiob pushed a commit to claudiob/view_component that referenced this pull request Jan 3, 2024
* fix bug where Compiler was not available

* add changelog

* vale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: uninitialized constant ViewComponent::Compiler
4 participants