-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ruby head matcher #2035
Merged
joelhawksley
merged 10 commits into
ViewComponent:main
from
reeganviljoen:rv-fix-ruby-main
May 31, 2024
Merged
Fix Ruby head matcher #2035
joelhawksley
merged 10 commits into
ViewComponent:main
from
reeganviljoen:rv-fix-ruby-main
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@boardfish I know you are working on more support for ruby 3.4 thats upcoming, can you take a look at this |
joelhawksley
approved these changes
May 31, 2024
Thanks @reeganviljoen! |
Its a pleasure 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix Ruby Main in Ci
What approach did you choose and why?
when using
assert_match
and a string is represented in the regexp pattern with two different opening/closing quotes(`')The error in Ruby main before the fix
Anything you want to highlight for special attention from reviewers?
we do not have Ruby main in Ci so it would be beneficial for reviewers to run the test suite against ruby head locally until it becomes a part of CI