Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby head matcher #2035

Merged
merged 10 commits into from
May 31, 2024
Merged

Conversation

reeganviljoen
Copy link
Collaborator

@reeganviljoen reeganviljoen commented May 28, 2024

What are you trying to accomplish?

Fix Ruby Main in Ci

What approach did you choose and why?

when using assert_match and a string is represented in the regexp pattern with two different opening/closing quotes(`')

The error in Ruby main before the fix

Expected /undefined method `render_component'/ to match # encoding: US-ASCII
#    valid: true
"undefined method 'render_component' for an instance of #<Class:0x0000000111930960>".

Anything you want to highlight for special attention from reviewers?

we do not have Ruby main in Ci so it would be beneficial for reviewers to run the test suite against ruby head locally until it becomes a part of CI

@reeganviljoen
Copy link
Collaborator Author

@boardfish I know you are working on more support for ruby 3.4 thats upcoming, can you take a look at this

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@joelhawksley joelhawksley merged commit b0a8e0c into ViewComponent:main May 31, 2024
39 checks passed
@joelhawksley
Copy link
Member

Thanks @reeganviljoen!

@reeganviljoen
Copy link
Collaborator Author

Thanks @reeganviljoen!

Its a pleasure 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants