Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eslint as dev dependancy ? #226

Closed
Nalca opened this issue Dec 13, 2018 · 1 comment
Closed

Adding eslint as dev dependancy ? #226

Nalca opened this issue Dec 13, 2018 · 1 comment

Comments

@Nalca
Copy link

Nalca commented Dec 13, 2018

Hello,

After fixing some undeclared vars in src/Filter/Fold.js (see #225) , I tried using eslint to find some errors and ...

More than 40 files use undeclared files.
You can be sure it's gonna explode if you use this code in strict mode ("use strict";). It did exploded for me when i used the folding filter.

This project should use a linter, even if it's not used in the build process. Just to find all those silly things that can throw Errors when executed.

@Viglino
Copy link
Owner

Viglino commented Dec 16, 2018

I've publish a bulk of fixes 😄 and eslint only return error on jQuery as we are removing it from the project asap.

@Viglino Viglino closed this as completed Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants