Standardize client and method names #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods from the OrderClient to the RefundClient
Rename ListPrimaryBalanceTransactionsAsync to GetPrimaryBalanceTransactionListAsync Rename ListBalancesAsync to GetBalanceListAsync
Viincenttt
added a commit
that referenced
this pull request
Jun 7, 2024
* Remove the optional retryPolicy parameter from AddMollieApi (#356) * Enable nullable references in Mollie.Api project (#346) * Upgrade language version to 12 * Enable nullable references * Add PolySharp so we can use required and init keyword * Change all models from class to record * Increase version number to 4.0.0 * Remove empty IResponseObject interface, as we don't need it * Fix editorconfig warnings (#358) * Fix editorconfig errors * Fix build warnings * Remove "this." from codebase * Fixing build editor suggestions * Enable nullable references in Blazor project * Fix more editor config issues * WIP: Use ModelName -> Request/Response namespaces everywhere * Use ModelName -> Request/Response namespaces everywhere * Remove unused using statements * Fix null reference issues * 11 warnings to go * Add more XML comments and fix all editorconfig warnings * Fix unit test * Standardize client and method names (#359) * Rename DeletePayment to CancelPayment in PaymentClient * Move the "Create order refund" method and the "List order refunds" methods from the OrderClient to the RefundClient * Rename GetChargebacksListAsync to GetChargebackListAsync for consistency * Rename GetCapturesListAsync to GetCaptureListAsync * Rename GetShipmentsListAsync to GetShipmentListAsync * Rename GetOrganizationsListAsync to GetOrganizationListAsync * Rename ListBalanceTransactionsAsync to GetBalanceTransactionListAsync Rename ListPrimaryBalanceTransactionsAsync to GetPrimaryBalanceTransactionListAsync Rename ListBalancesAsync to GetBalanceListAsync * Standardize method names in ISettlementsClient * Standardize client names, all clientnames are now singular * Standardize API names in readme * Allow null values for the Amount property in PaymentLinkRequest (#360) * Replace init with set in all models (#363) * Use { get; set; } everywhere instead of { get; init; } so we can continue to support lower C# language versions * Create payment specific mandate response types (#364) * Add payment specific response methods in mandate api * Create Json converter to parse mandate payment specific responses * Generate a new PaypalBillingAgreementId every time the CanCreatePayPalMandate integration test runs * Remove PayPal integration test, it is not supported on our account * Update GetBalanceTransactionListAsync and GetPrimaryBalanceTransactionListAsync methods to use a ListResponse instead of a custom type (#365) * #362 Update GetBalanceTransactionListAsync and GetPrimaryBalanceTransactionListAsync methods to use a ListResponse instead of a custom type * #362 Add GetBalanceTransactionListAsync method to retrieve a list of balance transactions by URL * Fix CanCreateSpecificPaymentType integration test * Fix issue where Links property of PaymentResponse would be null for BankTransferPaymentResponse --------- Co-authored-by: Gerard Gunnewijk <gerard.gunnewijk@live.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.