unset OnDebugLn when destroying

Villavu · Jan 14, 2024 · 5ddcb78 · 5ddcb78
1 parent b9feea5
commit 5ddcb78
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/Source/forms/simba.main.pas b/Source/forms/simba.main.pas
@@ -192,7 +192,6 @@   TSimbaForm = class(TForm)
     procedure MenuItemACAClick(Sender: TObject);
     procedure MenuItemAssociateScriptsClick(Sender: TObject);
     procedure MenuItemImageToStringClick(Sender: TObject);
-    procedure MenuItemConsoleClick(Sender: TObject);
     procedure MenuItemDocumentationClick(Sender: TObject);
     procedure MenuItemDTMEditorClick(Sender: TObject);
     procedure MenuItemFindNextClick(Sender: TObject);
@@ -944,11 +943,6 @@ procedure TSimbaForm.MenuItemResetLayoutClick(Sender: TObject);
   QueueOnMainThread(@DoResetDocking);
 end;
 
-procedure TSimbaForm.MenuItemConsoleClick(Sender: TObject);
-begin
-  SimbaSettings.General.ConsoleVisible.Value := TMenuItem(Sender).Checked;
-end;
-
 procedure TSimbaForm.MenuItemLockLayoutClick(Sender: TObject);
 begin
   SimbaSettings.General.LockLayout.Value := TMenuItem(Sender).Checked;

diff --git a/Source/forms/simba.outputform.pas b/Source/forms/simba.outputform.pas
@@ -96,6 +96,7 @@   TSimbaOutputForm = class(TForm)
     function GetActiveOutputBox: TSimbaOutputBox;
   public
     constructor Create(AOwner: TComponent); override;
+    destructor Destroy; override;
 
     property SimbaOutputBox: TSimbaOutputBox read FSimbaOutputBox;
     property ActiveOutputBox: TSimbaOutputBox read GetActiveOutputBox;
@@ -636,5 +637,12 @@ constructor TSimbaOutputForm.Create(AOwner: TComponent);
   SimbaIDEEvents.Register(Self, SimbaIDEEvent.TAB_CHANGE, @DoScriptTabChange);
 end;
 
+destructor TSimbaOutputForm.Destroy;
+begin
+  OnDebugLn := nil;
+
+  inherited Destroy();
+end;
+
 end.
 
diff --git a/Source/simba.settings.pas b/Source/simba.settings.pas
@@ -86,7 +86,6 @@   TSimbaSettings = class
     FIsLoading: Boolean;
   public
     General: record
-      ConsoleVisible: TSimbaSetting;
       TrayIconVisible: TSimbaSetting;
       Layout: TSimbaSetting;
       LockLayout: TSimbaSetting;
@@ -318,7 +317,7 @@ procedure TSimbaSetting.Changed;
   if FSettings.IsLoading then
     Exit;
 
-  DebugLn('[TSimbaSettings] Setting changed: ' + FName);
+  // DebugLn('[TSimbaSettings] Setting changed: ' + FName);
 
   I := FChangeEventList.Count;
   while FChangeEventList.NextDownIndex(I) do
@@ -477,7 +476,6 @@ constructor TSimbaSettings.Create;
   FList := TSettingList.Create();
 
   // General
-  General.ConsoleVisible     := TSimbaSetting_Boolean.Create(Self, 'General', 'ConsoleVisible', True);
   General.TrayIconVisible    := TSimbaSetting_Boolean.Create(Self, 'General', 'TrayIconVisible', True);
   General.LockLayout         := TSimbaSetting_Boolean.Create(Self, 'General', 'LockLayout', False);
   General.Layout             := TSimbaSetting_BinaryString.Create(Self, 'General', 'Layout', '');