Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin system to workit #216

Merged
merged 3 commits into from
Nov 27, 2020
Merged

feat: add plugin system to workit #216

merged 3 commits into from
Nov 27, 2020

Conversation

OlivierAlbertini
Copy link
Member

@OlivierAlbertini OlivierAlbertini commented Nov 11, 2020

  • My pull request adheres to the following guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.

closes #217

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #216 (d75fcc8) into master (55b08bd) will increase coverage by 2.86%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   70.22%   73.08%   +2.86%     
==========================================
  Files          49       50       +1     
  Lines        1041     1111      +70     
  Branches      133      142       +9     
==========================================
+ Hits          731      812      +81     
+ Misses        310      299      -11     
Impacted Files Coverage Δ
packages/workit-bpm-client/src/camundaBpmClient.ts 96.00% <75.00%> (-2.51%) ⬇️
packages/workit-zeebe-client/src/zeebeClient.ts 71.42% <75.00%> (+0.34%) ⬆️
packages/workit-core/src/plugin/pluginLoader.ts 88.46% <88.46%> (ø)
packages/workit-core/src/config/container.ts 95.45% <100.00%> (+0.45%) ⬆️
packages/workit-core/src/IoC.ts 34.06% <0.00%> (+23.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b08bd...d75fcc8. Read the comment docs.

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini merged commit 3d28cab into VilledeMontreal:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plugin loading system to workit
3 participants