Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages widget, translations post_meta #118

Merged
merged 3 commits into from Feb 3, 2019
Merged

Conversation

xanderdin
Copy link
Contributor

This PR adds languages widget and translations post meta partial for multi-language sites.

The widget:

widget

The 'Translations' post meta:

post_meta

Working example: https://xanderdin.github.io

Related config.toml excerpts:

...
[Params]
    post_meta = ["date", "categories", "translations"]
...
[Params.sidebar]
    widgets = ["search", "languages", "recent", "categories", "taglist", "social"]
...
[Languages.en]
     languageCode = "en"
     languageName = "English"
...
[Languages.ru]
     languageCode = "ru"
     languageName = "Русский"
...

All text translations in i18n are made by Google Translate (except Russian), so probably check by native speakers is required.

@Vimux
Copy link
Owner

Vimux commented Jan 29, 2019

Hi, @xanderdin

Good proposal. However, extra work needed. Today I have no spare time for code review. I'll check it back tomorrow. Sorry!

layouts/partials/widgets/languages.html Outdated Show resolved Hide resolved
layouts/partials/post_meta/translations.html Outdated Show resolved Hide resolved
@@ -12,6 +12,9 @@
- id: meta_lastmod
translation: Zuletzt geändert

- id: meta_translations
Copy link
Owner

@Vimux Vimux Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkel,
could you please verify this translation file?

@@ -12,6 +12,9 @@
- id: meta_lastmod
translation: "Última modificación"

- id: meta_translations
Copy link
Owner

@Vimux Vimux Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fervilber,
could you please verify this translation file?

i18n/fr.yaml Show resolved Hide resolved
@Vimux Vimux merged commit a70c0e7 into Vimux:master Feb 3, 2019
@Vimux
Copy link
Owner

Vimux commented Feb 3, 2019

@xanderdin,

Thank you for contribution.

@xanderdin xanderdin deleted the multilang branch February 3, 2019 15:51
alpiquero pushed a commit to alpiquero/Mainroad that referenced this pull request Feb 11, 2019
lockshell pushed a commit to lockshell/Mainroad that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants