Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login not working with I.E. #17

Closed
myofficesetup opened this issue Jun 12, 2013 · 21 comments
Closed

Login not working with I.E. #17

myofficesetup opened this issue Jun 12, 2013 · 21 comments

Comments

@myofficesetup
Copy link

Since installing, this stops customers from being able to login with Internet Explorer (Any version, but for sure 9 and 10)

I added this code which fixes that Magento - IE Issue for login and works fine, except when using this extension:

<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta http-equiv="X-UA-Compatible" content="IE=8" />

If I put this in: Observer.php in the directory:
app/code/community/Netzarbeiter/CustomerActivation/Model
I get an error when logging in with any browser, but when I hit the back button, it logs in, even in IE. Any idea on the fix for customer login with IE? I am using magento 1.7.0.2

Love the extension though
Thanks =)

@Vinai
Copy link
Owner

Vinai commented Jun 12, 2013

What error exactly are you getting?

@myofficesetup
Copy link
Author

Just reloads the page, no error messages or nothing. Unless you put the wrong username/password, then it will say "Invalid login or password."

@myofficesetup
Copy link
Author

Is there any luck with a fix for this? Extension says its compatible with Magento v1.7

@Vinai
Copy link
Owner

Vinai commented Jun 13, 2013

The extension works fine with Magento 1.7. It will be a few weeks until I get around to trying to reproduce and debug this, especially since it's browser dependent, and the extension actually doesn't change any frontend related logic, except for the HTTP Location header.
I'm sorry to say this issue has a low priority, there are more important things to work on for my free modules before it.

If you find the reason and a proper solution, I'll be happy to merge a pull request though.

@myofficesetup
Copy link
Author

Is there any way we can get it working sooner then a few weeks? I am looking to fix it today for my client. I know the file to alter is Observer.php , and just adding the code below makes it work, but first after you login, you will see an error stating the error is on that file, then when you hit the back button, it logs you in. So it makes it work but with an error in between.

<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta http-equiv="X-UA-Compatible" content="IE=8" />

This code actually fixes it, but needs the right place to put it in the observer.php file. If you can please assist me on this in a quicker manner, I will greatly appreciate it, plus this will be a bug fix that I assisted with =)

Thanks much, hopefully you can help by today/tomorrow. I can have myself and my client make a contribution to your company.

@Vinai
Copy link
Owner

Vinai commented Jun 14, 2013

The Observer.php file most certainly is not the correct place to output HTML code.
Before I can attempt to fix it, I need to understand completely why it is happening, and what the "fix" does, since I do not want to introduce unwanted side effects.

The event observer will be executed on the server, whenever a customer attempts to log in.
If the user account isn't activated, the login session won't be valid.
Since all of this happens only in the server context, the browser doesn't really come into play.

I could imagine IE to handle HTTP redirect headers differently then other browsers, but on the server side there is no difference.
When I have time I'll look into it, but I'm afraid I'll won't be able to do that sooner.

@myofficesetup
Copy link
Author

Any update? I would really need to get this going. Other than that, I would uninstall until you came up with a fix, but even uninstalling doesn't fix the issue even though IE login was working prior. I have great respect for your developing skills and admire your extensions however, my customer has plenty of clients calling regarding the issue so they would rather wait for the fix then have IE not working in the mean time. , so can you assist me with removing the extension completely where it goes back to normal or if you have the fix, i would MUCHHH rather have that, you did a great job with it.

Thanks bud,
Paul

@Vinai
Copy link
Owner

Vinai commented Jun 19, 2013

If there would be an update I would have updated the issue.
But, as I said before, I don't think the extension is actually causing the problem. If you deinstall the module there is no way it can still be influencing the login process in any way.

I'll look into this at one point, but don't wait for it. I suggest you go ahead and remove the extension if time is critical.

@myofficesetup
Copy link
Author

It was working great until I installed the B2B application which required
and auto-installed your app as well, since then, IE does not allow login,
even after removing your app and the B2B, and i made no other changes. I am
not trying to point fingers, but I have been developing with Magento since
1.2 and know when an extension causes an issue, and just because you remove
it, does not mean everything goes back to normal. If you want me to
demonstrate, I can give you an extension to try, remove, and see if your site
still functions the same.

Please let me know what to do to get this back working as it was prior to
installing

@Vinai
Copy link
Owner

Vinai commented Jun 23, 2013

Sorry, but if you're such a pro with Magento development, and you "know when an extension causes an issue", tell me why it's happening and how to fix it.

@myofficesetup
Copy link
Author

That's the weird part, is I fixed every area of login, and to no prevail.
Now you want to be a smart ass? I can also show you how far up the
food-chain I go with Magento and X Commerce, and see if you can still put your
extensions up on their website. I asked to see if you can fix your extension,
then I asked if you can remove it, and in the process , I even offered to pay
since the code you have is opennig php and not closing. I fixed your
extension to an extent, but it shows an error, then hit BACK on the browser, and
you are logged in, which is further than you got with your own extension.
So even offering you $ to fix this, it seems you are just happy to see
another developer not do well?

I can hire someone to do this so I dont have to. But instead of someone
learning the weird way of the way you did your coding, I thought it be best
from you.

Now, if you want, get back to me. If not, wait about 4 days and see who
conitacts you regarding this issue. Your extension/extensions will be taken
down until you fix the bug, and it will be 99% my bug you would have to fix
before it's aloud to be posted again, and I do not think the B2B extension
will do good without a required extension.

Why can;t you admit your extension has a bug, and either you do not want to
or do not know how to fix it. It should take you less than 15 minutes if
YOU know what YOU are doing. because I put in 2 lines and got 90% of the
work done, all you'd have to do is find the right way to implement it in a PHP
file that has no closing statement.

Take your pick. I do not see why you got ignorant, especially when I am
asking nicely and also offering to pay you.

Paul Youhanna
Founder & President
800.670.9370 Ext. 7701 (http://myofficesetup.com/) m_yOfficeSetup, INC._
(http://myofficesetup.com/)

In a message dated 6/23/2013 4:42:45 A.M. Central Daylight Time,
notifications@github.com writes:

Sorry, but if you're such a pro with Magento development, and you "know
when an extension causes an issue", tell me why it's happening and how to fix
it.

@Vinai
Copy link
Owner

Vinai commented Jun 23, 2013

Lol, I'm curious. Your attitude is quite entertaining.

No, honestly. This is a free extension, that thousands of store owners use. So far you are the only one with this complaint.
I've never said my products where bug free, but I've got much more important issues to spend my time on. You're on your own with this one, especially since you chose to "show me how far up the food chain you go" :D
Now I want to know.

BTW, thanks for the offer to pay me, but I'm not doing this for the money. It's called "Free Open Source Software".

@Vinai Vinai closed this as completed Jun 23, 2013
@benmarks
Copy link

Sorry, I am going to have to reopen this issue since you forgot to close that PHP statement in that file. The nerve!

I'm sure Paul looked at your LinkedIn profile to determine that he outranks you.

@danslo
Copy link

danslo commented Jun 23, 2013

Fun fact: This is a pretty well known bug and it has nothing to do with customer-activation.

Have fun finding it @myofficesetup 👎

@myofficesetup
Copy link
Author

I have the fix, i found it quite some time ago, maybe 2 weeks after IE9 came out, work the same for IE10. You can copy and paste it from the top of the screen. This is really weird, you app says it works for 1.7, it doesn't. So that;s a problem right there...if you know theres a bug, remove the version # or say THIS DOES NOT WORK WITH IE...just common courteous. Next, I have no reason to lie, I'm going to fix it myself anyway since you don't seem to know your own work, Every browser, every version, was working until I insalled B2B which also installs your app. Now unless the blame is for B2B, then not sure, but it wouldnt make sense.

READ THIS PART:
I have saved your extension and installed it on a clean WORKING 1.7 mage which works with IE login, 8 9 and 10 - IE STOPPED WORKING. After UNINSTALLING YOUR EXTESNION - IE STILL NOT WORKING. So nice way to back up your word ;) Try it, learn your app, learn how to COMPLETELY DEVELOP & DEBUG, then post.... it would make more sense.

@myofficesetup
Copy link
Author

Instead of taking the time to talk down to me, you could have tried that and realized your app does mes up IE, used my coding to fix it, and release a new version. You would have been done.

@myofficesetup
Copy link
Author

@benmarks , no,, not in LinkedIn, I have my friends that work for Magento. And I don't need LinkedIn. I own myOfficeSetup, INC. - A privately traded corporation which you can check with US Business Mags and findout what my company is worth.

I would pay for a fully working version of your app. You did a great job, i just cant believe you would get ignorant over the fact that i pointed out a flaw/bug in your extension, and then try to pass blame after a couple weeks.... even though you MAY know developing, you DO NOT know business,Sorry to say.

@benmarks
Copy link

@myofficesetup in all fairness and doing my best to obey my mantra to not feed the trolls, you have a fatal flaw in your diagnostic steps:

After UNINSTALLING YOUR EXTESNION - IE STILL NOT WORKING

If you had truly uninstalled the extension, the "clean WORKING 1.7 mage" instance would be identical to its pre-customer activation extension state. There would therefore be no way that the module ethereally causes some problem if all of its contents are gone. The possible "gothca" in an uninstall would be residual data; reference the setup script folder to see that none of these scripts have an effect on content rendered to the browser for frontend users.

It sucks when your system doesn't work, but given the number of functioning installations of this extension, the ability and thoroughness of its maintainer, and the lack of knowledge evident in your attempt to stick raw text in a completely inappropriate place in the extension that the burden of proof remains heavily on you.

Stick with it, I'm sure you'll get it figured out.
/thread

@myofficesetup
Copy link
Author

Your right, I should remove it. Your extension does rock. The only reason
why I was saying that bs' ie because im under pressure from my client
because most of their customers use IE, and it did (truly) stop working for IE
after installing the extension. But let me see if I can delete those
comments, especially on the magento connect page. My apologies. I appreciate you
providing your extensions for free. I just cant figure out why it won't work
with IE anymore, even though I uninstalled, and I made no other changes to
the site except installing the Business2Business extension, which forces to
install your extension as well. I am trying to find a fix for the
extension being installed and working with IE. When I figure the fix, I will send
it to you incase you run into this with anyone else. Again, my apologies for
not just emailing you my thoughts, instead, posting them on the board. I
will try deleting them now and apologize on the forum and say it was due to
another extension or a missing line of code or something.

The only weird part is when your extension is installed, and I put the fix
for IE code in the observer.php of your extension, after pressing login on
the IE page, I go to an error page instead of IE just refreshing the page
and emptying the fields. Then when i hit the Back button, it actually logs
me in. (Prety weird)

But again, I am sorry for the dumb comments, I will post it was my fault
not yours or the extensions, and remove any dumb comments.

Paul Youhanna
Founder & President
800.670.9370 Ext. 7701
myOfficeSetup, INC. (http://myofficesetup.com/)

In a message dated 6/24/2013 1:52:19 P.M. Central Daylight Time,
notifications@github.com writes:

@myofficesetup (https://github.com/myofficesetup) in all fairness and
doing my best to obey my mantra to not feed the trolls, you have a fatal flaw
in your diagnostic steps:
After UNINSTALLING YOUR EXTESNION - IE STILL NOT WORKING
If you had truly uninstalled the extension, the "clean WORKING 1.7 mage"
instance would be identical to its pre-customer activation extension state.
There would therefore be no way that the module ethereally causes some
problem if all of its contents are gone. The possible "gothca" in an uninstall
would be residual data; reference the setup script folder
(https://github.com/Vinai/customer-activation/tree/master/app/code/community/Netzarbeiter/Cu
stomerActivation/sql/customeractivation_setup) to see that none of these
scripts have an effect on content rendered to the browser for frontend
users.
It sucks when your system doesn't work, but given the number of functioning
installations of this extension, the ability and thoroughness of its
maintainer, and the lack of knowledge evident in your attempt to stick raw text
in a completely inappropriate place in the extension that the burden of
proof remains heavily on you.
Stick with it, I'm sure you'll get it figured out.
/thread

Reply to this email directly or view it on GitHub
(#17 (comment)) .

@VimS
Copy link

VimS commented Jun 28, 2013

I cant take it anymore.
Would you be so nice to test the following:

Go to: Magento backend -> Sytem -> Configuration -> Web -> Session and Cookie Management
Set cookie lifetime to 86400 (or 0) and save.

@myofficesetup
Copy link
Author

Thank you very much, I actually had to remove all cookie info, (Path
domain and lifetime). You rock!!

Paul Youhanna
Founder & President
800.670.9370 Ext. 7701
myOfficeSetup, INC. (http://myofficesetup.com/)

In a message dated 6/28/2013 8:04:40 A.M. Central Daylight Time,
notifications@github.com writes:

I cant take it anymore.
Would you be so nice to test the following:
Go to: Magento backend -> Sytem -> Configuration -> Web -> Session and
Cookie Management
Set cookie lifetime to 86400 (or 0) and save.

Reply to this email directly or view it on GitHub
(#17 (comment)) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants