Android hardware artifacting fix #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! We were having this exact problem. |
|
Having the same problem. Will use this library once patched! |
|
Awesome! @VincentCATILLON any update or timeline on when this will be released? |
There was a problem hiding this comment.
Hey @leezumstein,
what a nice job, thanks for your (very nice) contribution 🚀
I got few questions and improvements suggestions
| @@ -64,7 +69,7 @@ describe('index', () => { | |||
| expect(handleAnimationEnd).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| it('should not start is autoStart is disabled', () => { | |||
| it('should not start if autoStart is disabled', () => { | |||
Co-authored-by: Vincent Catillon <contact@vincent-catillon.fr>
|
@VincentCATILLON Thanks for taking the time to look at the PR, really appreciate all the feedback. All of your comments should now be addressed; simplified a lot needed to correct the Android artifacting issues. |
VincentCATILLON
approved these changes
Mar 3, 2021
|
Thanks a lot, i really appreciate our communication on this PR. |
|
@leezumstein Just added you as a contributor: 26e3f5a 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making two tweaks to handle artifacting issues that are occurring on different Android devices.
Changes
{ perspective: 100 }transform to the transform array (see documentation here).renderToHardwareTextureAndroidprop that defaults totrue(see documentation here)renderToHardwareTextureAndroidpropValidation
Please Note: To verify the artifacting issue is resolved, you'll need an Android device such as a Pixel 4, a recent Samsung device, or any of the OnePlus devices.
npmif already done, so you can confirm the presence of artifacting before testing> npm unlink> npm run android> npm run copy-filesResult
You should no longer have artifacting issues when running the application. Example before and after below on a OnePlus 7 Pro.
Related issues