Add change base distribution example #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentStimper
requested changes
Jun 1, 2023
There was a problem hiding this comment.
Hi @kazewong,
that's a great point and contribution! Could you please remove the generated output of the notebook to keep the repository size at bay and add a heading to the notebook? Then I'm happy to merge.
Best regards,
Vincent
|
@VincentStimper, I have removed the generated output and add heading. |
VincentStimper
approved these changes
Jun 2, 2023
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this PR as part of JOSS review openjournals/joss-reviews#5361
One of the biggest benefit of this package from a user point of view is one can change the base distribution easily. I have tried doing that in other packages but it was pretty tedious in general, whereas in this package one can simply define the
forwardandlog_probfunction and be done with it. I think this is a nice feature to highlight in the repo (at least in word so the users are aware of that. The authors have already highlighted this in the draft but it would nice to see it on the repo since there is where most of the people will look first.)I made a simple example script demonstrating this capability, by basically fetching the two moons example and training on it with a Gaussian mixture as the base distribution, which makes the training more stable and the final result nicer. Feel free to add more comments around it.