Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Objection.js used for tests to latest 1.0.0 RC. #32

Merged
merged 1 commit into from Jan 23, 2018
Merged

Update Objection.js used for tests to latest 1.0.0 RC. #32

merged 1 commit into from Jan 23, 2018

Conversation

kibertoad
Copy link
Collaborator

No description provided.

kapouer
kapouer approved these changes Jan 23, 2018
View reviewed changes
Copy link
Collaborator

@kapouer kapouer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i guess that means you plan to release a new version when 1.0 comes out ?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a9d39c7 on general/objection-1.0 into 543e250 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a9d39c7 on general/objection-1.0 into 543e250 on master.

@kibertoad
Copy link
Collaborator Author

@kapouer Yeah, I would like to. I presume I still don't have rights to publish, though? Any chance you could publish current RC release, btw?

@kibertoad kibertoad merged commit bcc8475 into master Jan 23, 2018
@kibertoad kibertoad deleted the general/objection-1.0 branch January 23, 2018 00:26
@kibertoad
Copy link
Collaborator Author

@kapouer CI has failed due to Node 4 no longer being supported by Objection, sorry for missing that. Created a follow-up PR for that.

@kapouer
Copy link
Collaborator

kapouer commented Jan 23, 2018

Done !

@kapouer
Copy link
Collaborator

kapouer commented Jan 23, 2018

@kibertoad npm owner add kibertoad objection-find done too.

@kapouer
Copy link
Collaborator

kapouer commented Jan 23, 2018

@kibertoad note that i published pre-version with
npm publish --tag rc
Because i don't like these versions tagged as latest.

@kapouer
Copy link
Collaborator

kapouer commented Jan 23, 2018

Goo dnight !

@kibertoad
Copy link
Collaborator Author

@kapouer Thanks and good night!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapouer kapouer kapouer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kibertoad @coveralls @kapouer