fix: improved typing for ModelObject<T> #2276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ModelObject does not preserve
?
optional properties.Example:
It's not surprising since with this declaration we lose the
?
optional syntaxTypescript has a native
Pick<Type, Keys>
utility Type for this which preserves optional properties and allows a shorter syntax.Not sure if it can be used also for
PartialModelObject
What do you think ?