Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could you allow to pass in the React Loop #12

Closed
andho opened this issue Oct 21, 2016 · 3 comments
Closed

Could you allow to pass in the React Loop #12

andho opened this issue Oct 21, 2016 · 3 comments

Comments

@andho
Copy link

andho commented Oct 21, 2016

I have an existing app that's running on React. I'm replacing the WebSocket server with Minion, but I need to keep other things that depends on it.

As a library, please allow the user to pass in an instance of the Loop as mentioned in the documentation: https://github.com/reactphp/event-loop.
@Mulkave
Copy link
Member

Mulkave commented Nov 11, 2016

@andho Thanks for the suggestion, how do you see that happen? In a service provider somewhere or to a specific class?

@NeoVance NeoVance mentioned this issue Apr 9, 2018
Merged
@NeoVance
Copy link

NeoVance commented Apr 9, 2018

@Mulkave @andho Fixed by #20

@Mulkave
Copy link
Member

Mulkave commented Apr 11, 2018 •
edited
Loading

Great, thanks @NeoVance.

@Mulkave Mulkave closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andho @Mulkave @NeoVance