Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes the behaviour of MultipleFactory and implements build speed overrides. #660

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Changes the behaviour of MultipleFactory and implements build speed overrides. #660

wants to merge 6 commits into from

Conversation

CCHyper
Copy link
Contributor

@CCHyper CCHyper commented Oct 15, 2021

Closes #106, Closes #656, Closes #657, Closes #658, Closes #659

This pull request covers multiple related items;

  • Changes the effect of the MultipleFactory bonus to be the same as Red Alert 2 when calculating an object's build time. Now, this is a straight discount multiplier that is cumulative.

  • [TechnoTypes]
    BuildTimeMultiplier=<float>
    Multiplier to the time it takes for an object to be built. Defaults to 1.0.

  • [General] (RULES.INI)
    LowPowerPenaltyModifier=<float>
    The "double penalty" or "half penalty". Multiply this by the power units you are short of to get the actual penalty to the build speed. Defaults to 1.0.

  • WorstLowPowerBuildRateCoefficient and BestLowPowerBuildRateCoefficient now have an effect on the production times when in a low power state. Previously there were not used.

  • [General] (RULES.INI)
    MultipleFactoryCap=<integer>
    The maximum number of factories that can be considered when calculating the multiple factory bonus on an object's build time. Defaults to 0 (no limit).

@CCHyper CCHyper added new-feature New feature or request. vanilla-bug Something isn't working in the original game quality-of-life Potential "Quality of life" (QoL) improvement. labels Oct 15, 2021
@CCHyper CCHyper added this to the RA2/YR Features milestone Oct 15, 2021
@CCHyper CCHyper requested a review from a team October 15, 2021 16:16
@github-actions
Copy link

github-actions bot commented Oct 15, 2021 •
edited

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@CCHyper CCHyper force-pushed the develop branch 4 times, most recently from 58dc156 to 1b504cc Compare October 16, 2021 21:59
@Bittah
Copy link

Bittah commented Oct 28, 2021 •
edited

With MultipleFactory=0.8 it takes this many seconds to produce a refinery with the specified number of factories:
1: ~23
2: ~15
3: ~12
4: ~9
5: ~7
6: ~6
7: ~5
8: ~4

With MultipleFactory=0.5 it takes this many seconds to produce a refinery with the specified number of factories:
1: ~23
2: ~6
3: ~3
4: ~1

And with MultipleFactory=0 and MultipleFactory=1 it always takes ~23 seconds to produce a refinery.

In YR with MultipleFactory=0.8 producing a refinery takes ~20 seconds for 1 ConYard, ~16 seconds for 2 ConYards and ~12 seconds for 3 ConYards
and with MultipleFactory=0.5 it takes ~9.5 seconds for 2 ConYards and ~4.5 seconds for 3 Conyards.

All tests were done at 60 FPS.

@CCHyper CCHyper force-pushed the multiple-factory-fix branch 3 times, most recently from 5ef5031 to 877a513 Compare October 29, 2021 01:00
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from eb03022 to 8ed42ec Compare January 21, 2022 22:45
@CCHyper CCHyper force-pushed the develop branch 14 times, most recently from ee4b285 to cbd21fc Compare February 24, 2022 01:06
@CCHyper CCHyper force-pushed the develop branch 4 times, most recently from 7ddd745 to 388e448 Compare April 1, 2022 01:16
@CCHyper CCHyper force-pushed the multiple-factory-fix branch 2 times, most recently from 48b781f to c5633bb Compare September 22, 2022 16:28
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 07c9446 to 379970b Compare November 9, 2022 14:53
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from 48cd2ea to b789478 Compare December 22, 2022 08:32
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 0edebb5 to 590971f Compare February 22, 2023 20:11
@CCHyper CCHyper force-pushed the multiple-factory-fix branch 2 times, most recently from 6abdbfd to 8fab0a8 Compare February 22, 2023 21:34
@CCHyper CCHyper self-assigned this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CCHyper CCHyper

Labels
new-feature New feature or request. quality-of-life Potential "Quality of life" (QoL) improvement. vanilla-bug Something isn't working in the original game
Projects
None yet
Milestone
RA2/YR Features
2 participants
@CCHyper @Bittah