-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-line genre editing #928
add multi-line genre editing #928
Conversation
fixes #914 |
d06e018
to
aa6fbcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please drop the album_genre_multiple
and use 'genre_multipe` instead string?
Now I do agree with you but if you look at the artist line, the same logic could apply there. If you look up the artist id3 tags they should be being set per song (mapped across all songs in the album) and not on a album wide basis (e.g in a specific album-artist field), unless we're doing something extra spicy behind the scenes (I didn't check, just assuming). So would you like me to also remove the album_artist_multiple string and just use artist_multiple? This would reduce translation burden |
Hi,
There are two separated tags for per-song and per-album artist(s).
Thanks for the modifications on the genre.
S
…On Tue, Jan 30, 2024, 01:56 Sarah ***@***.***> wrote:
Now I do agree with you but if you look at the artist line, the same logic
could apply there. If you look up the artist id3 tags they should be being
set per song and not on a album wide basis, unless we're doing something
extra spicy behind the scenes (I didn't check, just assuming). So would you
like me to also remove the album_artist_multiple and just use
artist_multiple?
—
Reply to this email directly, view it on GitHub
<#928 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFXH2VCZWQEUJQQYAU64ZTYRBAMXAVCNFSM6AAAAABCOP6ELWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVHA2TOMRYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Adds new string and updates album and song tag editors to allow the one-per-line style input. Genre parsing already handles this, so this was only a UI change