Allow tag editor to function on API 30+ #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further investigation suggests the API 21+ version of this utility does nothing harmful and should request the correct permission. the SAFGuideActivity is even set up for API 30+ |
Closed
|
I dont have an SD card myself to test it with, but currently the API 30+ functionality of the app just doesnt write files at all unless you had previously used the app in the API 21-29 and granted access to the SD card. So this change allows you to grant that permission in API 30+, as well as only showing the dialog if SD card is actually required. It defaults to just writing the file if it is allowed to write. |
gaycodegal
force-pushed
the
tag-editor-fix
branch
from
25aad92
to
2862796
Compare
soncaokim
approved these changes
Feb 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #863
In all technicality, this check does nothing and has no side effects. We don't gate solely on SD card access for other API versions, and the checking state to request any necessary permissions for the code occurs elsewhere. So we should not do this check here.