Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor multi select #958

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Refactor multi select #958

merged 7 commits into from
Mar 20, 2024

Conversation

soncaokim
Copy link
Collaborator

@soncaokim soncaokim commented Feb 22, 2024 •
edited

Related to #950

  • multi select songs and add to queue -> the added elements in the queue doesnt follow the same order as they are interactivity selected
  • bad index crash while swiping played elements out of queue - is this a regression due to this PR?

@soncaokim soncaokim added the bug label Feb 29, 2024
@soncaokim soncaokim marked this pull request as ready for review March 12, 2024 08:41
@soncaokim
Copy link
Collaborator Author

I've been using a CI version with this PR integrated since a week, and this works OK to me.
Please have a look on this, if no comment/veto I'll merge it in the next few days.

Thanks

@soncaokim soncaokim merged commit 6628e76 into master Mar 20, 2024
2 checks passed
@soncaokim soncaokim deleted the refactor-multi-select branch March 20, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienPoupa AdrienPoupa Awaiting requested review from AdrienPoupa

@Octoton Octoton Awaiting requested review from Octoton

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@soncaokim