Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translations): add Dutch translation #986

Merged

Conversation

AnonymousWP
Copy link
Contributor

@AnonymousWP AnonymousWP commented Mar 17, 2024

@soncaokim Hi, I think this should fix it (I removed the redundant ones). There something for you to be done though I think before this can be merged, see here. For example "is translated here but not found in default location". I guess this means the string (in the default language) is not used in the application.

@soncaokim
Copy link
Collaborator

For example "is translated here but not found in default location". I guess this means the string (in the default language) is not used in the application.

Yes, these strings are removed. Can you please remove them from the Dutch translation?

@AnonymousWP
Copy link
Contributor Author

Done.

Copy link
Collaborator

@soncaokim soncaokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soncaokim soncaokim merged commit 21e5b86 into VinylMusicPlayer:master Mar 18, 2024
@AnonymousWP AnonymousWP deleted the add-missing-Dutch-strings branch March 18, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants