#VP-2481 add shipment item select #157
Conversation
| toolbarCommands: [ | ||
| { | ||
| name: "orders.commands.add-selected", icon: 'fa fa-plus', | ||
| executeMethod: function (blade) { |
There was a problem hiding this comment.
| blade.toolbarCommands = [ | ||
| { | ||
| name: "orders.commands.add-item", icon: 'fa fa-plus', | ||
| executeMethod: function (blade) { |
There was a problem hiding this comment.
|
yes, we could add more then 1 item to shipment items. |
src/VirtoCommerce.OrdersModule.Web/Scripts/blades/customerOrder-items-select.js
Show resolved
Hide resolved
| { | ||
| ModelLineItem = shipmentItem.LineItem; | ||
| } | ||
| ModelLineItem = shipmentItem.LineItem; |
There was a problem hiding this comment.
Could you test these scenarios to be confident that you don't introduce regress bugs?
- save new order with the new shipment with items
- update exists order shipment with new shipment items
- update exists order with the new shipment with items
There was a problem hiding this comment.
I guess, there is no scenario - save new order with the new shipment with items.
How to do it? Without exists LineItemId?
there are no links with Order.LineItemId.
Microsoft.Data.SqlClient.SqlException (0x80131904): Cannot insert the value NULL into column 'LineItemId', table 'VirtoCommerce3.dbo.OrderShipmentItem'; column does not allow nulls. INSERT fails.
@akak1977 saving new shipment - fixed
…VP-2481-add-shipment-item-select
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. 2 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
No description provided.