Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allPackages.js (PLATFORM\VirtoCommerce.Platform.Web\Scripts) out-of-sync? #250

Closed
jvdonk opened this issue Jan 25, 2016 · 1 comment
Closed
Assignees

Comments

@jvdonk
Copy link

jvdonk commented Jan 25, 2016

Download latest release source, 2.6(b39c463), unpack.

Open in VS(make sure your NPM is up to date, see #247 ;)) so that the bower.json and package.json dependencies are restored.

Than in Task Runner Explorer, run the gulp packAll task, the outputted allPackages.js is different from what was distributed in source.

Is my build process wrong? Or is the distributed allPackages.js build with a different set of javascript files: bower dependencies or Platform .js files?

@eMazeika
Copy link

JavaScript is minified during the script generation process. It's ok if the generated result isn't identical. You should be worried only if the resulting allPackages.js file size is much different from the original one.
P.S. usually the Platform Manager doesn't even start, if a package is missing in allPackages.js

@eMazeika eMazeika self-assigned this Jan 25, 2016
@eMazeika eMazeika added this to the v2.7 'Needles' milestone Jan 26, 2016
@eMazeika eMazeika removed this from the 2.8 'Chanterelle' milestone Feb 5, 2016
@eMazeika eMazeika closed this as completed Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants