VCST-914: Critical CVE-2018-1000210 (#681) #601
OlegoOAnnotations
10 warnings
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/Common/AnonymousComparer.cs(20,23): warning S3260: Private classes which are not derived in the current assembly should be marked as 'sealed'. (https://rules.sonarsource.com/csharp/RSPEC-3260) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/Common/AnonymousComparer.cs(105,23): warning S3260: Private classes which are not derived in the current assembly should be marked as 'sealed'. (https://rules.sonarsource.com/csharp/RSPEC-3260) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/Common/StringExtensions.cs(16,1): warning S103: Split this 1025 characters long line (which is greater than 300 authorized). (https://rules.sonarsource.com/csharp/RSPEC-103) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/Security/SecurityConstants.cs(45,1): warning S103: Split this 313 characters long line (which is greater than 300 authorized). (https://rules.sonarsource.com/csharp/RSPEC-103) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/AddressType.cs(6,17): warning S2342: Rename this enumeration to match the regular expression: '^([A-Z]{1,3}[a-z0-9]+)*([A-Z]{2})?s$'. (https://rules.sonarsource.com/csharp/RSPEC-2342) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/AddressType.cs(8,9): warning S2346: Rename 'Undefined' to 'None'. (https://rules.sonarsource.com/csharp/RSPEC-2346) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/BankCardInfo.cs(31,23): warning S100: Rename property 'BankCardCVV2' to match pascal case naming rules, consider using 'BankCardCvv2'. (https://rules.sonarsource.com/csharp/RSPEC-100) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/Common/ValueObject.cs(84,25): warning S134: Refactor this code to not nest more than 3 control flow statements. (https://rules.sonarsource.com/csharp/RSPEC-134) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/Common/TypeExtensions.cs(54,25): warning S109: Assign this magic number '3' to a well-named variable or constant, and use that instead. (https://rules.sonarsource.com/csharp/RSPEC-109) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|
|
ci
/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/StaticContent/ContentItem.cs(83,29): warning S3776: Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776) [/home/runner/work/vc-storefront/vc-storefront/VirtoCommerce.Storefront.Model/VirtoCommerce.Storefront.Model.csproj]
|