Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Migrate theme to new storefront version with Scriban view engine #79

Closed
tatarincev opened this issue Apr 4, 2019 · 3 comments
Closed
Assignees
Labels

Comments

@tatarincev
Copy link
Contributor

tatarincev commented Apr 4, 2019

The primary objective is allow to run the vc-theme-default with the new storefront that powered by new Scriban, end-user liquid template engine

Technical details:

@tatarincev tatarincev added this to the Operations milestone Apr 4, 2019
@ilyawzrd
Copy link
Contributor

@tatarincev, i made a commit 1e1c422 to branch with scriban theme and also made a comment VirtoCommerce/vc-storefront#188 (comment) about syntax change,but still have few problems here:

  1. Can't show "Sign in/Create an account" links. I guess it's because of property "shop.customer_accounts_enabled", but i can't find it

    {% if settings.header_message != blank or shop.customer_accounts_enabled %}

  2. Same as 1)

    {% if settings.header_message != blank or shop.customer_accounts_enabled %}

  3. It shows an error that something wrong with "For" loop.
    List-collections

    {% for link in linklists.all-collections.links %}

  4. allVariationPropsMap is a variable from assets/js/product.js, but function getFlatternDistinctPropertiesMap returns empty object when i debug it. I think it can be something with dependency script locally,because in old version of theme i have the same result without showing props.

    <div ng-repeat="(propName, props) in allVariationPropsMap">

    $scope.allVariationPropsMap = getFlatternDistinctPropertiesMap(allVariations);

  5. "For" loop is not working.

    {% for cat_item in collection.all_tags.groups %}

  6. Images and prices for products are not showing

    <img src="{{ product.featured_image.src | img_url }}" alt="{{ product.featured_image.alt | escape }}" />

@trueboroda
Copy link
Contributor

A new problem has been found. When you use site search an error occurs.
image

tatarincev added a commit that referenced this issue Jun 28, 2019
* Changes to run theme in scriban templating engine

* Remove named arguments for all pipe functions calls  (not supported in current scriban template engine)
Remove arguments for all Include statements
Replace  == blank  to .empty? == false check

* Remove AJAX load for product prices
Update theme to work with new data context (not finished)

* Changes in syntax to run theme with scriban

* Removed custom order collections by 'all-collections' linklist,
scriban syntax fix

* Sing in link shoing in header. solved. #83

* collection-sidebar.liquid problem was resolved.

* Problem "Images and prices for products are not showing" was resolved.
#87

* Added indents

* Product search functionality is repaired

* left code n comments was deleted

* product price actual price showing in search and collectiono-list pages

* price product snipped was extracted from prduct-grid-item, product-list-item and search-result-grid snippets Due to eliminate duplication

* small fix in search.liquid

* migration of localization files

* static page showing was fixed

* properly date showing in blogs page. also corrected another usings of dates filters in  liquid and angular markaups

* anonymous checkout page showing is fixed

* sidbar filter is rapaired. Multiple choise under one agr group.

* Process navigation links through absolute_url filter
@tatarincev
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants