Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Added packJavaScript task to default gulp task #181

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

loktar00
Copy link

@loktar00 loktar00 commented Sep 9, 2021

When running the default gulp task the scripts_dependencies.js file is never created, this is required to run the templates otherwise you receive an error. The default task also cleans the directory removing the file if it was there and doesn't regenerate it.

This PR just adds the packJavaScript task which generates the above file so a user can run the default task in order to test their template changes.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jason Brown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mvktsk
Copy link
Contributor

mvktsk commented Sep 9, 2021

Review task https://virtocommerce.atlassian.net/browse/VP-7709 has been created

@loktar00 loktar00 force-pushed the gulp-default-task-fix branch 2 times, most recently from a27e51a to 5c2c7e1 Compare September 9, 2021 20:32
@loktar00
Copy link
Author

loktar00 commented Sep 9, 2021

Sorry for the weird commit there.. new machine git creds weren't setup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants