Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hacktoberfest 2022 badge to profile #658

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Add Hacktoberfest 2022 badge to profile #658

merged 2 commits into from
Oct 4, 2022

Conversation

adiati98
Copy link
Sponsor Contributor

@adiati98 adiati98 commented Oct 4, 2022 •
edited by danieltott
Loading

  • Add flare
  • Edit Hashnode's username

Linked Issue

#643

Description

  • Add Hacktoberfest 2022 badge to Ayu's member profile.
  • Add flare
  • Edit Hashnode's username.

Methodology

Code of Conduct

By submitting this pull request, you agree to follow our Code of Conduct

@adiati98
Add Hacktoberfest 2022 badge
906e4f9 
* Add flare
* Edit Hashnode's username
@netlify
Copy link

netlify bot commented Oct 4, 2022 •
edited
Loading

👷 Deploy Preview for virtual-coffee-io processing.

Name Link
🔨 Latest commit e5a6aa7
🔍 Latest deploy log https://app.netlify.com/sites/virtual-coffee-io/deploys/633c2a37f289360009524198

@adiati98 adiati98 marked this pull request as ready for review October 4, 2022 11:11
@adiati98
Copy link
Sponsor Contributor Author

adiati98 commented Oct 4, 2022 •
edited
Loading

Hi @danieltott,
I have some questions out of curiosity.

I generated a Personal Access Token and followed all the steps in the original issue.
But I couldn't preview the member page locally.
It keeps kicking me out from yarn dev or yarn start and gives me this error.

Local Netlify Application Error

So I made the changes blindly and hoping that I can preview it on Netlify deploy preview generated on GH after I created PR.
But I got this error messages instead.

Netlify Application Error

I've looked around the closed PRs from other members, and I can preview them (except for the images).

Do you have any thoughts why this happen?
TIA! 😊

danieltott
danieltott requested changes Oct 4, 2022
View reviewed changes
members/members/adiati98.ts Outdated Show resolved Hide resolved
danieltott
danieltott approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@danieltott danieltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

david s. pumkpins

@danieltott danieltott merged commit f8404ba into Virtual-Coffee:main Oct 4, 2022
@adiati98
Copy link
Sponsor Contributor Author

adiati98 commented Oct 4, 2022

@danieltott
Morticia Addams thank you GIF

@adiati98 adiati98 deleted the ayu-add-badge branch October 4, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieltott danieltott danieltott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adiati98 @danieltott