Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript conversion: app/component/HomePageBlock #725

Merged
merged 2 commits into from Oct 21, 2022
Merged

Typescript conversion: app/component/HomePageBlock #725

merged 2 commits into from Oct 21, 2022

Conversation

lsparlin
Copy link
Contributor

@lsparlin lsparlin commented Oct 19, 2022 •
edited by danieltott

Linked Issue

Description

Convert HomePageBlock component to typescript

  • Add Home Page Block prop type
  • export and use UndrawIllustrationName from UndrawIllustration component

Methodology

Code of Conduct

By submitting this pull request, you agree to follow our Code of Conduct

@netlify
Copy link

netlify bot commented Oct 19, 2022 •
edited

👷 Deploy Preview for virtual-coffee-io processing.

Name Link
🔨 Latest commit 2bb56af
🔍 Latest deploy log https://app.netlify.com/sites/virtual-coffee-io/deploys/63506a20d9f1040008cfe16d

danieltott
danieltott requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@danieltott danieltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @lsparlin! Just one small change (see comments)

app/components/HomePageBlock.tsx Outdated Show resolved Hide resolved
danieltott
danieltott approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@danieltott danieltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boom

@danieltott danieltott merged commit 7f9a98c into Virtual-Coffee:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieltott danieltott danieltott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert HomePageBlock.jsx to TypeScript
2 participants
@lsparlin @danieltott