Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links and typos in monthly challenges, September, and October challenge pages #973

Merged
merged 7 commits into from Aug 29, 2023
Merged

Fix broken links and typos in monthly challenges, September, and October challenge pages #973

merged 7 commits into from Aug 29, 2023

Conversation

adiati98
Copy link
Sponsor Contributor

@adiati98 adiati98 commented Aug 28, 2023

Linked Issue

Refers to #969

Description

We have some broken links to our resources — and to some other external links — in our monthly challenges pages and we want to fix them.

Because Preptember (then Hacktoberfest) is coming soon, I prioritized fixing the September (sept-2021.jsx, sept-2022.jsx), October (oct-2021.jsx, oct-2022.jsx), and monthly challenges (monthlychallenges/index.tsx) pages. Therefore, this PR will not close the issue yet.

This PR fixes the links and changes some other things in the list below:

  • Fixed broken links.
  • Fixed semantic HTML.
  • Fixed typos and minor wordings adjustments.
  • Import LeadText and Link, and applied them to replace <p className="lead"> and <a href=""> for internal links.
  • Added alert message in the completed challenges.

Pages Live Preview

Methodology

Code of Conduct

By submitting this pull request, you agree to follow our Code of Conduct

* Fix semantic HTML
* Import Link and Leadtext
* Fix typos and adjust wordings
* Add alert challenge is complete
* Import Link and LeadText
* Fix typos and adjust wordings
* Import Link & LeadText
* Fix typos and adjust wordings
* Add alert challenge is complete
* Import Link and LeadText
* Fix typos and adjust wordings
….tsx

* Import Link
* Fix typos and minor wordings adjustments
@adiati98 adiati98 requested a review from a team as a code owner August 28, 2023 19:17
@netlify
Copy link

netlify bot commented Aug 28, 2023

👷 Deploy Preview for virtual-coffee-io processing.

Name Link
🔨 Latest commit 47d8dff
🔍 Latest deploy log https://app.netlify.com/sites/virtual-coffee-io/deploys/64ecf2f3ba0d10000865a169

@adiati98
Copy link
Sponsor Contributor Author

@danieltott @BekahHW
I fixed the broken links to our VC guide pages in the Monthly Challenges, September, and October challenge pages so we can reuse them for the coming challenges.
I will work on the rest later :)

Please let me know if I need to fix anything here.
Thank you!

Copy link
Member

@danieltott danieltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Thank you @adiati98 !!!!

@danieltott danieltott merged commit ffb46a4 into Virtual-Coffee:main Aug 29, 2023
5 checks passed
@adiati98 adiati98 deleted the ayu_fix_links-challenges branch August 30, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants