Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image SEO not working when you use the link #44

Closed
Baasie opened this issue Mar 13, 2021 · 2 comments
Closed

Image SEO not working when you use the link #44

Baasie opened this issue Mar 13, 2021 · 2 comments
Assignees
@Baasie
Labels
bug Something isn't working

Comments

@Baasie
Copy link
Collaborator

Baasie commented Mar 13, 2021 •
edited
Loading

The link to the SEO now points to the object, instead of the publicURL.
@Baasie Baasie added the bug Something isn't working label Mar 13, 2021
@Baasie Baasie self-assigned this Mar 13, 2021
Baasie added a commit that referenced this issue Mar 13, 2021
@Baasie
Added the publicURL and static url to the SEO image for #44
0464ab8
@Baasie
Copy link
Collaborator Author

Baasie commented Mar 13, 2021

Did two things:

  • the default image is now under the static folder and the defaultImage is pointing to that image so that always works now.
  • for dynamic images like for sessions, I have added the publicURL variable in the gatbsy query and added that to the SEO. locally it seems to work, but could not find the static image before once deployed. Now checking what happened after everything deployed like this

@Baasie
Copy link
Collaborator Author

Baasie commented Mar 13, 2021

Fixed and deployed

@Baasie Baasie closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baasie Baasie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Baasie