Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images rendered from github markdown files are linked falsly #47

Closed
yellowbrickc opened this issue Mar 23, 2021 · 1 comment
Closed

Images rendered from github markdown files are linked falsly #47

yellowbrickc opened this issue Mar 23, 2021 · 1 comment
Assignees
@yellowbrickc
Labels
bug Something isn't working

Comments

@yellowbrickc
Copy link
Contributor

Images included in github files are rendered to /static/.../jpg. These are handled in markdown-links.tsx like relative paths and this leads to broken links (the images are to find in /static)
@yellowbrickc yellowbrickc self-assigned this Mar 23, 2021
@yellowbrickc yellowbrickc added the bug Something isn't working label Mar 23, 2021
yellowbrickc added a commit that referenced this issue Mar 23, 2021
@yellowbrickc
#47 fix links to static images loaded from markdown
81071f4
@yellowbrickc
Copy link
Contributor Author

Fixed

@yellowbrickc yellowbrickc mentioned this issue Mar 24, 2021
Closed
yellowbrickc added a commit that referenced this issue Mar 31, 2021
@yellowbrickc
#47 consider the preview on netlify as "same domain"
4a722dd
yellowbrickc added a commit that referenced this issue Mar 31, 2021
@yellowbrickc
#47 handle links for github user
9fa2b77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yellowbrickc yellowbrickc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yellowbrickc