Dropping use of register keyword #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of register keyword was deprecated in c++14 and it's completely removed in c++17. Found will building virtualgl on gentoo with clang-16. Bug: https://bugs.gentoo.org/898876 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
|
Not sure why GitHub is suddenly not listing the commit that refers to this PR, but the fix was integrated in 441c4e7. |
dcommander
pushed a commit
that referenced
this pull request
Jun 7, 2023
The 'register' keyword was deprecated in C++11 and removed in C++17, so usage of that keyword in VirtualGL (more specifically in the in-tree FLTK and MD5 code, not in the VGL code itself) prevented successful compilation with newer compilers (e.g. Clang 16) unless -Wno-register was specified. Fixes https://bugs.gentoo.org/898876 Closes #233
dcommander
pushed a commit
that referenced
this pull request
Jun 7, 2023
The 'register' keyword was deprecated in C++11 and removed in C++17, so usage of that keyword in VirtualGL (more specifically in the in-tree FLTK and MD5 code, not in the VGL code itself) prevented successful compilation with newer compilers (e.g. Clang 16) unless -Wno-register was specified. Fixes https://bugs.gentoo.org/898876 Closes #233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of register keyword was deprecated in c++14 and it's completely removed in c++17. Found will building virtualgl on gentoo with clang-16.
Bug: https://bugs.gentoo.org/898876