vlgrun.in: requires bash #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following is not allowed by posix:
```
exec ${1+"$@"}
```
9 tasks
|
The ci seems to be broken for different reason. |
|
That line was contributed by my fellow employees of Sun Microsystems in 2005, and at the time, we thoroughly tested the product on Solaris 8, which doesn't have BASH. Unless you can demonstrate that vglrun fails on a non-BASH Bourne-compatible shell, then I cannot accept this patch. |
|
cc @markuskowa |
|
@Mic92 I am actually having trouble reproducing the error. Sorry for the confusion. |
|
@markuskowa I guess then our patch can be reverted. |
|
Yes, it seems our patch is unnecessary. Sorry again for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is not allowed by posix: