Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use layered concentric infinite cylinders with refractive index mismatch #122

Closed
hayakawa16 opened this issue Oct 30, 2023 · 2 comments · Fixed by #133
Closed

Add ability to use layered concentric infinite cylinders with refractive index mismatch #122

hayakawa16 opened this issue Oct 30, 2023 · 2 comments · Fixed by #133
Assignees
@janakarana

Comments

@hayakawa16
Copy link
Member

MultiConcentricInfiniteCylinderTissue already exists, however does not currently allow for refractive index between layers and between outer cylinder and enclosing layer region. Comments in place in GetReflectedDirection and GetRefractedDirection to do this because trial code was coded before.
@hayakawa16
Copy link
Member Author

I need this for my work now too. It looks like no code has been pushed yet to branch? I can help. Let me know where you stand on the code updates.

@janakarana
Copy link
Member

Please go ahead. I will push my changes later

@hayakawa16 hayakawa16 linked a pull request Feb 22, 2024 that will close this issue
Feature/122 add ability to use layered concentric infinite cylinders with refractive index mismatch #133
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janakarana janakarana

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hayakawa16 @janakarana