Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change config file name #87

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

ltsNotMike
Copy link
Contributor

Ticket

Summary

What does this PR do/solve?

Changes misleading naming of the config file from "custom.js" to "plugins.js".

Test Plan

  • Install plugin to strapi project.
  • Add configuration
  • Check if the configuration is being applied

@ltsNotMike ltsNotMike self-assigned this Nov 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #87 (3f720a0) into master (8cab133) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   14.36%   14.36%           
=======================================
  Files           5        5           
  Lines         348      348           
  Branches      111      111           
=======================================
  Hits           50       50           
  Misses        238      238           
  Partials       60       60           
Flag Coverage Δ
unittest 14.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/utils/functions.js 47.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cab133...3f720a0. Read the comment docs.

@cyp3rius cyp3rius force-pushed the refactor/change-config-file-name branch from 3f720a0 to 8c9a6b5 Compare November 8, 2021 15:42
@cyp3rius cyp3rius merged commit 44cf5a6 into master Nov 8, 2021
@cyp3rius cyp3rius deleted the refactor/change-config-file-name branch November 8, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants