Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm cats from engine #226

Merged
merged 12 commits into from Feb 8, 2022

Conversation

KacperFKorban
Copy link
Member

This PR removes the dependency on cats and cats-effect from engine module.
Most notable changes:

  • replaced Monoid with custom implementation
  • replaced State with custom implementation
  • replaced EitherT[IO, _, _] used mostly in handler classes by a custom monad FutureExcept, which can be thought of as EitherT[Future, _, _]

@pikinier20 @BarkingBad
I would actually really appreciate the review. Specifically, I would like to hear your thoughts on the API changes i.e. changes in files OutputHandler InputHandler, ConfigReader, and InkuireRunner by extension.

@KacperFKorban KacperFKorban merged commit e049a18 into VirtusLab:master Feb 8, 2022
@KacperFKorban KacperFKorban deleted the rm-cats-from-engine branch February 8, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants