Poc #3
Poc #3
Conversation
|
As a general rule, pls mark the comments as resolved once they're ready ✅ |
| import sbt._ | ||
|
|
||
| object Dependencies { | ||
| val borerVersion = "1.6.3" |
There was a problem hiding this comment.
There's already Borer 1.7.0 AFAICS
There was a problem hiding this comment.
Or now 1.7.1 with #16 fixed ;)
There was a problem hiding this comment.
Whoops looks that 1.7+ is only for Scala 2.13... lemme discuss with the Borer author...
There was a problem hiding this comment.
Or maybe I'll manage to migrate Hydra to 2.13 right now, lemme see 
| import io.bullet.borer.Codec | ||
|
|
||
| import java.io.{ByteArrayInputStream, ByteArrayOutputStream, ObjectInputStream, ObjectOutputStream} | ||
| import java.time.OffsetDateTime | ||
|
|
||
| object StandardCodecs { | ||
|
|
||
| implicit def sinkRefCodec[T](implicit system: actor.ActorSystem = serializationSystem): Codec[SinkRef[T]] = { |
There was a problem hiding this comment.
Gr8, lemme quickly check on my commercial project (let's codename it Hydra from now on...)
There was a problem hiding this comment.
Whoops I'm blocked on this problem with type aliases (since borer 1.7.1 is not yet available for Scala 2.12, only 2.13)... let's leave as is for now
src/test/scala/org/virtuslab/akkasaferserializer/AkkaStreamSerializerSpec.scala
Outdated
Show resolved
Hide resolved
|
This PR's got pretty big, pls resolve the outstanding issues (esp. the CI build) and merge this one to master |
|
(and open new PRs for new stuff) |
src/test/scala/org/virtuslab/akkasaferserializer/AkkaStreamSerializerSpec.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/virtuslab/akkasaferserializer/CborAkkaSerializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/virtuslab/akkasaferserializer/BorerAkkaSerializer.scala
Show resolved
Hide resolved
src/main/scala/org/virtuslab/akkasaferserializer/BorerAkkaSerializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/virtuslab/akkasaferserializer/BorerAkkaSerializer.scala
Outdated
Show resolved
Hide resolved
|
Approving, but subject to fixing the tests 🤔 |
|
@PawelLipski should we use squash and merge, or rebase and merge? |
|
As you like, as long as the history of |
|
Typically I'm using just |
|
(FF merge gives the most predictable effects, as no new commit is created by GitHub behind the scenes, as would be the case with button-triggered Rebase or Squash) |
It seems we have used a merge once by accident. Untangling this will require some work. |
|
Ok than use squash button from web GH, this should not have this problem |
No description provided.