Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.getSecret shorthand config key name is broken #205

Closed
pawelprazak opened this issue Oct 2, 2023 · 4 comments · Fixed by #294
Closed

config.getSecret shorthand config key name is broken #205

pawelprazak opened this issue Oct 2, 2023 · 4 comments · Fixed by #294
Assignees
@pawelprazak
Labels
area/core The SDK's core code impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation kind/bug Some behavior is incorrect or out of spec P2 Bugs of moderate severity to be assigned to an engineer in the next iteration size/S Estimated effort to complete (1-2 days).
Milestone
0.2.0

Comments

@pawelprazak
Copy link
Collaborator

pawelprazak commented Oct 2, 2023 •
edited

The shorthand config key name is broken for secrets, this returns empty output:
val mySecret = config.getSecret("mySecret")

and when the key has the explicit namespace it works as expected:
val mySecret = config.getSecret("aws-secrets-manager:mySecret")

Relates to #204
@pawelprazak pawelprazak added kind/bug Some behavior is incorrect or out of spec area/core The SDK's core code impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation size/S Estimated effort to complete (1-2 days). labels Oct 2, 2023
@pawelprazak pawelprazak mentioned this issue Oct 2, 2023
Merged
@pawelprazak pawelprazak added this to the 0.2.0 milestone Oct 5, 2023
@pawelprazak pawelprazak added the P2 Bugs of moderate severity to be assigned to an engineer in the next iteration label Oct 19, 2023
@lbialy lbialy mentioned this issue Oct 31, 2023
Closed
3 tasks
@prolativ
Copy link
Collaborator

@pawelprazak is config.getSecret("aws-secrets-manager:mySecret") actually something that should work and be equivalent to Config("aws-secrets-manager").getSecret("mySecret")? Or is the latter variant the only that we would like to support?

@pawelprazak
Copy link
Collaborator Author

@pawelprazak is config.getSecret("aws-secrets-manager:mySecret") actually something that should work and be equivalent to Config("aws-secrets-manager").getSecret("mySecret")? Or is the latter variant the only that we would like to support?

This is a great question, we need to take a closer look at the upstream, preferably by porting more tests.

@pawelprazak
Copy link
Collaborator Author

Should be fixed by #287, will re-test

@pawelprazak pawelprazak self-assigned this Nov 13, 2023
@pawelprazak
Copy link
Collaborator Author

@prolativ I've double checked with the upstream docs and IIUC, the namespac-ed string version should work the same as explicitly namespaced.

pawelprazak added a commit that referenced this issue Nov 13, 2023
@pawelprazak
Test and document Config
1a5a920 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse

Fixes #204
Fixes #205
@pawelprazak pawelprazak mentioned this issue Nov 13, 2023
Merged
pawelprazak added a commit that referenced this issue Nov 13, 2023
@pawelprazak
Test and document Config
d394aea 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 13, 2023
@pawelprazak
Test and document Config
d260667 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 13, 2023
@pawelprazak
Test and document Config
e5c4c4b 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add instegration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak
Test and document Config
3cfa613 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add instegration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak
Test and document Config
45fd1b3 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak
Test and document Config
869c5bf 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak
Test and document Config
fc0592c 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak
Test and document Config
94f1330 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak @prolativ
Test and document Config
63cc162 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak @prolativ
Test and document Config
742a1f1 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
pawelprazak added a commit that referenced this issue Nov 14, 2023
@pawelprazak @prolativ
Test and document Config
033f60c 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
pawelprazak added a commit that referenced this issue Nov 15, 2023
@pawelprazak @prolativ
Test and document Config
4c648eb 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
pawelprazak added a commit that referenced this issue Nov 15, 2023
@pawelprazak @prolativ @lbialy
Test and document Config
e584e68 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
Co-authored-by: Łukasz Biały <lbialy@virtuslab.com>
pawelprazak added a commit that referenced this issue Nov 15, 2023
@pawelprazak @prolativ @lbialy
Test and document Config
a31bdef 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
Co-authored-by: Łukasz Biały <lbialy@virtuslab.com>
pawelprazak added a commit that referenced this issue Nov 15, 2023
@pawelprazak @prolativ @lbialy
Test and document Config
ff58488 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
Co-authored-by: Łukasz Biały <lbialy@virtuslab.com>
pawelprazak added a commit that referenced this issue Nov 15, 2023
@pawelprazak @prolativ @lbialy
Test and document Config (#294)
9999049 
- build on #287 to improve Config ergonomy
- add Output[Option[A]].orElse and .getOrElse
- add unit tests for Config
- add integration test for Config
- add Scaladoc for Config and other critical API surfaces

Fixes #204
Fixes #205

Co-authored-by: Michał Pałka <prolativus@gmail.com>
Co-authored-by: Łukasz Biały <lbialy@virtuslab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelprazak pawelprazak

Labels
area/core The SDK's core code impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation kind/bug Some behavior is incorrect or out of spec P2 Bugs of moderate severity to be assigned to an engineer in the next iteration size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Test and document Config VirtusLab/besom
2 participants
@pawelprazak @prolativ