Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add structured configuration #207

Closed
pawelprazak opened this issue Oct 2, 2023 · 0 comments · Fixed by #300
Closed

Add structured configuration #207

pawelprazak opened this issue Oct 2, 2023 · 0 comments · Fixed by #300
Labels
area/api User visible API impact/usability Something that impacts users' ability to use the product easily and intuitively kind/missing We are missing a part of functionality compared to upstream needs-design Needs from design work: architecture, API, DX/UX size/M Estimated effort to complete (up to 5 days).
Milestone
0.2.0

Comments

@pawelprazak
Copy link
Collaborator

pawelprazak commented Oct 2, 2023 •
edited

We are missing Structured Configuration in the API

Add:

  • def requireJson(key: NonEmptyString): Output[JsValue]
  • def requireObject[A: JsonFormat](key: (non-empty?)String): Output[A] = requireJson(key).map(_.convertTo[A])

Relates to #204
@pawelprazak pawelprazak added kind/improvement An improvement with existing workaround impact/usability Something that impacts users' ability to use the product easily and intuitively size/M Estimated effort to complete (up to 5 days). area/api User visible API needs-design Needs from design work: architecture, API, DX/UX kind/missing We are missing a part of functionality compared to upstream and removed kind/improvement An improvement with existing workaround labels Oct 2, 2023
@pawelprazak pawelprazak mentioned this issue Nov 13, 2023
Merged
pawelprazak added a commit that referenced this issue Nov 16, 2023
@pawelprazak
Add support for structural configs
0c660f4 
- add support for JSON configs, with AST and object results
- code and docs cleanup

Fixes #207
@pawelprazak pawelprazak mentioned this issue Nov 16, 2023
Merged
pawelprazak added a commit that referenced this issue Nov 20, 2023
@pawelprazak
Add support for structural configs
b674778 
- add support for JSON configs, with AST and object results
- code and docs cleanup

Fixes #207
pawelprazak added a commit that referenced this issue Nov 20, 2023
@pawelprazak
Add support for structural configs
76c7676 
- add support for JSON configs, with AST and object results
- code and docs cleanup

Fixes #207
pawelprazak added a commit that referenced this issue Nov 28, 2023
@pawelprazak
Add support for structural configs (#300)
e351b62 
* Add support for structural configs

- add support for JSON configs, with AST and object results
- code and docs cleanup

Fixes #207
@pawelprazak pawelprazak added this to the 0.2.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api User visible API impact/usability Something that impacts users' ability to use the product easily and intuitively kind/missing We are missing a part of functionality compared to upstream needs-design Needs from design work: architecture, API, DX/UX size/M Estimated effort to complete (up to 5 days).
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Add support for structural configs VirtusLab/besom
1 participant
@pawelprazak