Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traverse on Output #360

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix traverse on Output #360

merged 2 commits into from
Jan 31, 2024

Conversation

lbialy
Copy link
Collaborator

@lbialy lbialy commented Jan 31, 2024

uh, Iterable instead of IterableOnce, thanks Scala Collections!

@lbialy lbialy added kind/bug Some behavior is incorrect or out of spec area/core The SDK's core code impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation labels Jan 31, 2024
pawelprazak
pawelprazak approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@pawelprazak pawelprazak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a regression test and I've tested manually, the aws example, now passes

@pawelprazak pawelprazak mentioned this pull request Jan 31, 2024
Closed
@pawelprazak pawelprazak merged commit 0005efd into develop Jan 31, 2024
2 checks passed
@pawelprazak pawelprazak deleted the fix-traverse-on-output branch January 31, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelprazak pawelprazak pawelprazak approved these changes

Assignees
No one assigned
Labels
area/core The SDK's core code impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbialy @pawelprazak