fix transitive dependency resolution algorithm #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
added
P0
pawelprazak
approved these changes
Feb 6, 2024
| val childrenResult = current match | ||
| case cr: ComponentResource => ctx.resources.getStateFor(cr).map(_.children) | ||
| case _ => Result.pure(Set.empty) | ||
| case cb: ComponentBase => resources.getStateFor(cb).map(_.children.filterNot(_ == current)) |
| findAllReachableResources((left - current) ++ children, acc + current) | ||
| val updatedAcc = | ||
| current match | ||
| case dr: DependencyResource => // Dependency resources are added directly to the set, they don't have a state. |
lbialy
deleted the
lbialy/fix-transitive-dependency-resolution-algorithm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as in the title, we have had our impl from Java impl which was ported from C# impl which is broken and includes custom resource children of any other resources, including local, remote components and other custom resources, this works and is covered with an extensive test