Fix #383 - serializer now skips fields with null value secrets #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
force-pushed
the
pprazak/fix-383
branch
3 times, most recently
from
6035bba
to
2d7a0fe
Compare
lbialy
force-pushed
the
pprazak/fix-383
branch
from
552b9de
to
8a0364e
Compare
pawelprazak
force-pushed
the
pprazak/fix-383
branch
from
8a0364e
to
4ef02c6
Compare
pawelprazak
changed the title
pawelprazak
force-pushed
the
pprazak/fix-383
branch
4 times, most recently
from
dbda104
to
ba650a0
Compare
pawelprazak
force-pushed
the
pprazak/fix-383
branch
from
ba650a0
to
ff61ec8
Compare
pawelprazak
added
the
P1
pawelprazak
commented
Feb 14, 2024
lbialy
approved these changes
Feb 14, 2024
| @@ -405,6 +405,11 @@ DO NOT remove dependencies from `project.scala`, because they are necessary in b | |||
|
|
|||
| ## Troubleshooting | |||
|
|
|||
| If you susspect the issue is related to serialization, try to skip the preview (dry run is known to be problematic): | |||
| @@ -52,7 +52,8 @@ trait EffectBesomModule extends BesomSyntax: | |||
| config <- Config.forProject(runInfo.project) | |||
| featureSupport <- FeatureSupport(monitor) | |||
| _ <- logger.trace(s"Environment:\n${sys.env.toSeq.sortBy(_._1).map((k, v) => s"$k: $v").mkString("\n")}") | |||
| _ <- logger.debug(s"Resolved feature support, spawning context and executing user program.") | |||
| _ <- logger.debug(s"Resolved feature support: ${pprint(featureSupport)}") | |||
There was a problem hiding this comment.
Is pprint() returning a String or Unit? I am not sure if it just prints to stdout or converts into pretty printed string?
There was a problem hiding this comment.
it returns a Str and a toString is called, we already use it this way in the code so I did the same for consistency
| @@ -26,6 +25,9 @@ object EncoderTest: | |||
|
|
|||
| case class PlainCaseClass(data: String, moreData: Int) derives Encoder | |||
| case class OptionCaseClass(data: Option[String], moreData: Option[Int]) derives Encoder | |||
| case class InputOptionalCaseClass(value: Output[Option[String]], data: Output[Option[Map[String, Output[String]]]]) | |||
| derives Encoder, | |||
| ArgsEncoder | |||
There was a problem hiding this comment.
What's up with formatting here? 😁
There was a problem hiding this comment.
scalafmt had it's own idea ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
The actual fix done by @lbialy