Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 115] More strict type for matrix multiplication #132

Merged
merged 5 commits into from
Jan 18, 2022
Merged

[Issue 115] More strict type for matrix multiplication #132

merged 5 commits into from
Jan 18, 2022

Conversation

joannasendorek
Copy link
Collaborator

Solve for: #115

@joannasendorek joannasendorek self-assigned this Jan 17, 2022
@joannasendorek joannasendorek mentioned this pull request Jan 17, 2022
Closed
zkrolikowski-vl
zkrolikowski-vl approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@zkrolikowski-vl zkrolikowski-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy thinks that np.ndarray overlaps Series because it doesn't have any type information about np.ndarray and assumes it's Any

@joannasendorek joannasendorek merged commit 91e9672 into master Jan 18, 2022
@joannasendorek joannasendorek deleted the issue_115 branch January 18, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkrolikowski-vl zkrolikowski-vl zkrolikowski-vl approved these changes

Assignees

@joannasendorek joannasendorek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joannasendorek @zkrolikowski-vl