New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin option added twice #2708
Comments
--server=false does not generate bloop's json files I'm afraid |
@lbialy but it does pass plugin options to the compiler |
There never was any issue with compilation by scala-cli, the error crashes metals and metals only. |
Passed you a repro with minimization via slack. |
Tomasz suggests that this is what breaks Metals for me, diagnostics not being delivered. //> using scala "3.3.3"
//> using options -Werror -Wunused:all -Wvalue-discard -Wnonunit-statement
//> using plugin "org.virtuslab::besom-compiler-plugin:0.2.2"
//> using dep "org.virtuslab::besom-core:0.2.2"
//> using dep "org.virtuslab::besom-aws:6.23.0-core.0.2"
//> using dep "org.virtuslab::besom-awsx:2.5.0-core.0.2"
import besom.*
import besom.api.aws, besom.api.awsx
@main def main = Pulumi.run {
val bucket =
// THIS IS AN ERROR v <---- over here
aws.s3.Bucket("my-bucket", ws.s3.BucketArgs(forceDestroy = true))
Stack.exports(
bucketName = bucket.bucket
)
}
|
Yeah, this is a massive pita for us. Two things actually trigger this.
Compiler plugin is one thing. Second is
//> using options -language:noAutoTupling
No idea if this is the same problem or a completely different one.
…On Thu 28. Mar 2024 at 10:37, Anton Sviridov ***@***.***> wrote:
Tomasz suggests that this is what breaks Metals for me, diagnostics not
being delivered.
//> using scala "3.3.3"//> using options -Werror -Wunused:all -Wvalue-discard -Wnonunit-statement//> using plugin "org.virtuslab::besom-compiler-plugin:0.2.2"//> using dep "org.virtuslab::besom-core:0.2.2"//> using dep "org.virtuslab::besom-aws:6.23.0-core.0.2"//> using dep "org.virtuslab::besom-awsx:2.5.0-core.0.2"
import besom.*import besom.api.aws, besom.api.awsx
@main def main = Pulumi.run {
val bucket =
// THIS IS AN ERROR v <---- over here
aws.s3.Bucket("my-bucket", ws.s3.BucketArgs(forceDestroy = true))
Stack.exports(
bucketName = bucket.bucket,
// ecrRepo = repo.url,
// image = image.urn
)
}
CleanShot.2024-03-28.at.09.25.06.gif (view on web)
<https://github.com/VirtusLab/scala-cli/assets/1052965/90175895-536a-4396-aa11-57aa0804fb3c>
***@***.*** (view on web)
<https://github.com/VirtusLab/scala-cli/assets/1052965/ecbbcd0f-9858-44af-8e16-8d420961ef0e>
—
Reply to this email directly, view it on GitHub
<#2708 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVNUXWFFTPLJZPEPP6EDTY2PJC5AVCNFSM6AAAAABCTJIR3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUG43TGNRSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I've seen also this being trigerred by |
Version(s)
1.1.2
Describe the bug
When using:
the plugin option is sometimes added twice, but it doesn't seem to reproduce always/
Expected behaviour
Plugin option is added once.
The text was updated successfully, but these errors were encountered: