Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner specification #1445

Merged
merged 11 commits into from Nov 18, 2022
Merged

Conversation

romanowski
Copy link
Member

This commit tags commands, options and directives as MUST have, SHOULD have, IMPLEMENTATION details, Scala CLI specific and EXPERIMENTAL.

Added a new document describing the scope of proposed Scala Runner for our SIP.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented on some nitpicks and language, overall looks good

@Gedochao Gedochao added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Oct 13, 2022
@tgodzik
Copy link
Member

tgodzik commented Nov 14, 2022

Do we need to merge the PR or was it upstreamed somewhere for the SiP committee ?

@romanowski
Copy link
Member Author

fixes #1419

@romanowski romanowski force-pushed the runner-specification branch 2 times, most recently from 680dcfc to c7c131f Compare November 16, 2022 15:53
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SnippetOptions lack the @Tag annotation on --execute-markdown and --markdown-snippet options (can't comment on those lines as they're out of scope).
Otherwise, LGTM

@alexarchambault
Copy link
Contributor

Should be squash-and-merged, right?

@romanowski
Copy link
Member Author

yes

@alexarchambault alexarchambault enabled auto-merge (squash) November 18, 2022 09:20
@alexarchambault alexarchambault merged commit ca02f6e into VirtusLab:main Nov 18, 2022
@Gedochao Gedochao linked an issue Nov 18, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the Scala CLI runner
4 participants