Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'in' clause in require directives #164

Merged
merged 10 commits into from
Sep 30, 2021
Merged

Add support for 'in' clause in require directives #164

merged 10 commits into from
Sep 30, 2021

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault force-pushed the scoped-directives branch 2 times, most recently from 88c5268 to c47ea0c Compare September 30, 2021 09:14
@alexarchambault
Don't use generated sources for commented directives
6e83995 
When using and require directives are all commented, we can pass the
original Scala source as is to scalac, no need to replace the directives
by whitespaces.
@alexarchambault
Minor refacto
168f32f
@alexarchambault
Dummy refacto
fe86f69
@alexarchambault
Address unused parameter warning
894022b
@alexarchambault alexarchambault marked this pull request as ready for review September 30, 2021 09:34
@alexarchambault alexarchambault merged commit 808a8fc into VirtusLab:master Sep 30, 2021
@alexarchambault alexarchambault deleted the scoped-directives branch September 30, 2021 12:29
@alexarchambault
Copy link
Contributor Author

This is missing glob support (* to match file / dire names), but passing a directory to in already makes it apply to all files in it and its sub-directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alexarchambault