Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test sources and cross-building support #176

Merged
merged 20 commits into from
Oct 7, 2021

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Sep 30, 2021

No description provided.

@alexarchambault alexarchambault changed the title ? Add test sources support Oct 5, 2021
@alexarchambault alexarchambault force-pushed the test-sources branch 5 times, most recently from 51807e6 to 5f3cfe4 Compare October 6, 2021 07:47
@alexarchambault alexarchambault changed the title Add test sources support Add test sources and cross-building support Oct 6, 2021
@alexarchambault alexarchambault force-pushed the test-sources branch 3 times, most recently from 9bc48b6 to c61ed54 Compare October 6, 2021 12:41
@alexarchambault alexarchambault marked this pull request as ready for review October 6, 2021 12:41
@alexarchambault alexarchambault force-pushed the test-sources branch 10 times, most recently from a95293a to 7941899 Compare October 7, 2021 09:08
To make it easier to add cross-platform support in subsequent commits.
Useful for subsequent commits
So that each cross-build has a different project name.
Useful for cross-test support later on.
and doesn't override anything.

BuildOptions and the associated case classes shouldn't have Some(…)
values. These make 'BuildOptions().orElse(other)' override values in
'other', which breaks its semantics / assumptions. ('BuildOptions' is
supposed to be the "zero" or null value of BuildOptions as a monoid, and
is used more as such with the changes in this PR.)
@alexarchambault alexarchambault merged commit 4b65b94 into VirtusLab:master Oct 7, 2021
@alexarchambault alexarchambault deleted the test-sources branch October 7, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant