Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors #191

Merged
merged 6 commits into from
Oct 7, 2021
Merged

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault marked this pull request as ready for review October 6, 2021 16:51
@@ -78,15 +78,24 @@ final class BspImpl(
)
}

(sources, options0, classesDir0, artifacts, project, generatedSources, buildChanged)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudn't we create a case class for this long tuple so parameters etc. are named?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should at that point, yes.

@alexarchambault alexarchambault merged commit ded6dbd into VirtusLab:master Oct 7, 2021
@alexarchambault alexarchambault deleted the better-errors branch October 7, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants