Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak build / address compiler warnings #198

Merged
merged 9 commits into from
Oct 8, 2021
Merged

Tweak build / address compiler warnings #198

merged 9 commits into from
Oct 8, 2021

Commits on Oct 8, 2021

  1. Run JVM and JS docker tests on macOS and Windows too 

    It works there if docker is installed.
    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    23c65cc View commit details
    Browse the repository at this point in the history

  2. Clean-up

    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    8078f37 View commit details
    Browse the repository at this point in the history

  3. Dummy refacto 

    Useful for subsequent commits
    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    c31911e View commit details
    Browse the repository at this point in the history

  4. Get local repo JAR version from the JAR itself 

    So that we don't have to change Constants.scala everytime the git state
changes.
    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    3f54c94 View commit details
    Browse the repository at this point in the history

  5. Use a stale detailed version locally 

    So that Constants.scala doesn't get overwritten too often.

This should only bork the output of './mill scala about'.
    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    9206068 View commit details
    Browse the repository at this point in the history

  6. Disable compilation altogether for dummy modules 

    These modules are only here to ensure some dependencies are available.
No need to have Mill setup compilation for them.
    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    1bc5ecc View commit details
    Browse the repository at this point in the history

  7. Address compiler warnings

    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    6a480e3 View commit details
    Browse the repository at this point in the history

  8. Don't require cs to be installed any more

    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a3c4628 View commit details
    Browse the repository at this point in the history

  9. Update coursier to 2.0.16-161-g8a1b8eae5

    @alexarchambault
    alexarchambault committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    e332537 View commit details
    Browse the repository at this point in the history