Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update build output folder in Internal docs #2071

Merged
merged 1 commit into from May 4, 2023
Merged

Docs: Update build output folder in Internal docs #2071

merged 1 commit into from May 4, 2023

Conversation

amaalali
Copy link
Contributor

@amaalali amaalali commented May 3, 2023

No description provided.

@Gedochao
Copy link
Contributor

Gedochao commented May 4, 2023 •
edited

Hey, thanks for the contribution!
You marked the PR as a draft, are you still working on it? When you're done, please mark it as ready for review.
The fix looks valid as is, thanks for spotting it.

@amaalali
Copy link
Contributor Author

amaalali commented May 4, 2023 •
edited

@Gedochao The only other thing that I spotted in the docs was that in some of the snippets from running different commands that still have references to the old .scala/ folder, but I couldn't actually find where these snippets were displayed on the scala-cli site

@amaalali amaalali marked this pull request as ready for review May 4, 2023 09:51
Gedochao
Gedochao approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 63365ca into VirtusLab:main May 4, 2023
37 checks passed
@amaalali amaalali deleted the docs/update-build-output-folder-internals branch May 4, 2023 09:58
@Gedochao Gedochao added bug Something isn't working documentation Improvements or additions to documentation labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amaalali @Gedochao