Report errors for using directives in console and via BSP #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
using-directives-errors
branch
8 times, most recently
from
870d415
to
d9f92d1
Compare
alexarchambault
force-pushed
the
using-directives-errors
branch
3 times, most recently
from
6d218c8
to
04b7fc8
Compare
Useful in subsequent commits
So that we can report errors at the positions where we add dependencies.
We're trying to guess the target id that Bloop is going to give us. Depending on whether we use Java IO or NIO, or if the .scala directory already exists, the URI we infer might be subtly different than the one picked by Bloop, so that's a bit fragile… This URI used to be picked in the first messages we got from Bloop. It's useful here to reset directives diagnostics upon startup.
We make them start at 'using' rather than at '//'.
So that we get standard diagnostics for malformed or not-found dependencies.
BspTests are for the bsp sub-command, not the Bloop integration. Plus tests in BspTestDefinitions are run for each Scala version, which is not relevant for these tests.
Not sure it was doing what was expected, the version comparison was wrong in particular.
alexarchambault
force-pushed
the
using-directives-errors
branch
from
04b7fc8
to
4c40719
Compare
alexarchambault
force-pushed
the
using-directives-errors
branch
from
4c40719
to
850acbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.