Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove JavaInterface, which causes compilation issues with Bloop #2174

Merged
merged 1 commit into from May 31, 2023

Conversation

tgodzik
Copy link
Member

@tgodzik tgodzik commented May 31, 2023

I don't think it's used anywhere right now, but we could just move it to a separate module if needed.

@tgodzik
Copy link
Member Author

tgodzik commented May 31, 2023

@alexarchambault do we need that interface anywhere else or is it safe to remove? I can also just move it to another module.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexarchambault
Copy link
Contributor

alexarchambault commented May 31, 2023

do we need that interface anywhere else or is it safe to remove? I can also just move it to another module.

Yes, it's used by coursier bootstraps, IIRC. They're written in Java, and can read the proxy config and the default repository list from the Scala CLI config using this API. My bad, they don't rely on this anymore (they must have at some point, possibly only locally on my machine). I guess this can be removed.

@tgodzik tgodzik marked this pull request as ready for review May 31, 2023 13:13
@tgodzik tgodzik merged commit 35e2ac9 into VirtusLab:main May 31, 2023
38 checks passed
@tgodzik tgodzik deleted the remove-java-interface branch May 31, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants