Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the versions of Github CI runners #2370

Merged
merged 1 commit into from Aug 31, 2023
Merged

Pin the versions of Github CI runners #2370

merged 1 commit into from Aug 31, 2023

Conversation

MaciejG604
Copy link
Contributor

No description provided.

@tgodzik
Copy link
Member

tgodzik commented Aug 30, 2023

Looks like that's what we should do, I talked with Wojciech and he said it's safer to have a stable image. You can make it a normal PR

@MaciejG604 MaciejG604 changed the title WIP Pin the versions of Github CI runners Aug 31, 2023
@MaciejG604
Copy link
Contributor Author

Okay, I've made the PR and commits merge-ready, also added pinned version of the macOS runner (relevant Github docs)

tgodzik
tgodzik approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaciejG604 MaciejG604 merged commit dda7948 into VirtusLab:main Aug 31, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaciejG604 @tgodzik